Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify open source stance #100

Merged
merged 1 commit into from
Dec 1, 2023
Merged

docs: clarify open source stance #100

merged 1 commit into from
Dec 1, 2023

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented Nov 29, 2023

@codecov-commenter
Copy link

Codecov Report

Attention: 171 lines in your changes are missing coverage. Please review.

Comparison is base (445b365) 91.59% compared to head (46302ed) 69.01%.
Report is 74 commits behind head on main.

Files Patch % Lines
...r-steps/view-results/RelatedSkillsSingleBoxSet.jsx 4.25% 45 Missing ⚠️
...lect-preferences/CareerInterestCategorizinator.jsx 2.77% 34 Missing and 1 partial ⚠️
...ps/view-results/RelatedSkillsInteractiveBoxSet.jsx 0.00% 23 Missing ⚠️
.../skills-builder-steps/SkillsBuilderProgressive.jsx 6.66% 14 Missing ⚠️
src/skills-builder/ProductTool.jsx 9.09% 10 Missing ⚠️
...lls-builder/visibility-flags-context/data/hooks.js 9.09% 8 Missing and 2 partials ⚠️
...s-builder/visibility-flags-context/data/reducer.js 0.00% 7 Missing and 1 partial ⚠️
...builder-steps/view-results/RecommendationStack.jsx 72.22% 5 Missing ⚠️
.../skills-builder-steps/view-results/ViewResults.jsx 85.29% 5 Missing ⚠️
.../skills-builder-steps/view-results/data/service.js 55.55% 2 Missing and 2 partials ⚠️
... and 5 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #100       +/-   ##
===========================================
- Coverage   91.59%   69.01%   -22.59%     
===========================================
  Files          30       43       +13     
  Lines         369      639      +270     
  Branches       68      152       +84     
===========================================
+ Hits          338      441      +103     
- Misses         30      188      +158     
- Partials        1       10        +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

deborahgu
deborahgu approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@deborahgu deborahgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nedbat nedbat merged commit 51c4c61 into main Dec 1, 2023
4 checks passed
@nedbat nedbat deleted the nedbat/clarify-openedx branch December 1, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deborahgu deborahgu deborahgu approved these changes

@justinhynes justinhynes Awaiting requested review from justinhynes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nedbat @codecov-commenter @deborahgu